Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design system : implement new TextField #3834

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Design system : implement new TextField #3834

merged 9 commits into from
Nov 12, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Nov 7, 2024

Content

Implements new TextField (named TextField2 for now) using BasicTextField underneath.
Uses this new api for try in the ConfigureRoomView

Motivation and context

New design : https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=2008-37137

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/u3jzsF

@ganfra ganfra added PR-Misc For other changes Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Nov 8, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 8, 2024
@ganfra ganfra force-pushed the feature/fga/design_system_text_field branch from e6ef999 to acc6eb7 Compare November 8, 2024 15:28
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 8, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 8, 2024
@ganfra ganfra marked this pull request as ready for review November 8, 2024 15:29
@ganfra ganfra requested a review from a team as a code owner November 8, 2024 15:29
@ganfra ganfra requested review from jmartinesp and removed request for a team November 8, 2024 15:29
jmartinesp
jmartinesp approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.06061% with 50 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (ebfa50c) to head (324b3d0).
Report is 76 commits behind head on develop.

Files with missing lines Patch % Lines
...braries/designsystem/theme/components/TextField.kt 73.91% 35 Missing and 1 partial ⚠️
...in/impl/screens/loginpassword/LoginPasswordView.kt 79.16% 5 Missing ⚠️
...designsystem/modifiers/OnTabOrEnterKeyFocusNext.kt 16.66% 5 Missing ⚠️
...droid/libraries/designsystem/modifiers/Autofill.kt 84.61% 1 Missing and 1 partial ⚠️
...searchaccountprovider/SearchAccountProviderView.kt 85.71% 1 Missing ⚠️
...s/designsystem/theme/components/FilledTextField.kt 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3834      +/-   ##
===========================================
- Coverage    82.96%   82.84%   -0.13%     
===========================================
  Files         1776     1776              
  Lines        44775    44788      +13     
  Branches      5259     5265       +6     
===========================================
- Hits         37149    37106      -43     
- Misses        5787     5846      +59     
+ Partials      1839     1836       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 12, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 12, 2024
@ganfra ganfra merged commit cffd2da into develop Nov 12, 2024
28 of 30 checks passed
@ganfra ganfra deleted the feature/fga/design_system_text_field branch November 12, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganfra @jmartinesp @ElementBot